RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE
Mandy Chung
mandy.chung at oracle.com
Tue Aug 30 15:45:49 UTC 2016
Thanks Alejandro. A minor correction - the patch is pushed to jdk9/hs/hotspot which is the right repo to fix this issue.
I did a grep on jdk9/hs/hotspot/test and find no other test changes using the old CLI options. I have covered the necessary changes in jdk9/dev/hotspot/test in [1].
Mandy
[1] http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160851/webrev.00/index.html
> On Aug 29, 2016, at 11:40 PM, Alejandro Murillo <alejandro.murillo at oracle.com> wrote:
>
> Please push this to jdk9/dev after Mandy's change is in,
> to make sure the fix work, and that is there by Thursday when I take the snapshot
> otherwise there's not guarantee it will be part of the snapshot
>
> Thanks
> Alejandro
>
> On 8/30/2016 12:15 AM, Jini Susan George wrote:
>> Thank you, Mandy. Aiming at that.
>>
>> -jini.
>>
>>> -----Original Message-----
>>> From: Mandy Chung
>>> Sent: Tuesday, August 30, 2016 11:27 AM
>>> To: Jini Susan George
>>> Cc: David Holmes; serviceability-dev; Alejandro Murillo
>>> Subject: Re: RFR:(S): 8164562:
>>> serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE
>>>
>>>
>>>> On Aug 29, 2016, at 12:51 AM, Jini Susan George
>>> <jini.george at oracle.com> wrote:
>>>> Hi David,
>>>>
>>>> Thank you for the review. I have added a few more asserts and uploaded a
>>> modified webrev:
>>>> http://cr.openjdk.java.net/~jgeorge/8164562/webrev.01/
>>> Looks okay. It’d be helpful if you can make sure your fix can push to jdk9/hs
>>> and include in the next hs->dev push. Otherwise these tests without your fix
>>> will fail in jdk9/dev since the old CLI option will be removed.
>>>
>>> thanks
>>> Mandy
>>>
>
> --
> Alejandro
>
More information about the serviceability-dev
mailing list