RFR: JDK-8159127: hprof heap dumps broken for lambda classdata

[Dmitry Samersoff]

Jini,

I'm OK with removed null check.

Looks good to me!

-Dmitry

On 2016-12-15 11:57, Jini Susan George wrote:
> Thank you, Serguei for the review.  Comments inline.
> 
>> -----Original Message-----
>>
>>
>>    It seems there is no need to check address for null as it is done
>> inside the instantiateWrapperFor call.
> 
> Makes sense. I have removed those.
>   
>> At the lines 522-547 it is possible to define and use the same callback class
>> for traversing both the SystemDictionary classes and the anonymous classes.
>> The same is applied to the lines 961-990.
>> But I leave it up to you to decide if it needs to be updated.
> 
> I have left this as it is. The modified webrev is at:
> 
> http://cr.openjdk.java.net/~jgeorge/8159127/webrev.02/
> 
> Thanks,
> Jini.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.