RFR:8147847:serviceability/tmtools/jstat tests are failing with -XX:+ExplicitGCInvokesConcurrent

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Mon Feb 1 13:08:43 UTC 2016


On 1.2.2016 13:59, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review this trivial tests-only fix:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8147847 "serviceability/tmtools/jstat tests are failing with -XX:+ExplicitGCInvokesConcurrent"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8147847/index.html
>
> The changed tests compare the output from the "jstat -gc" (or from similar commands) before and after an explicit garbage collection has taken place.
> Therefore, the tests should not be executed if the option -XX:+ExplicitGCInvokesConcurrent is set.
> The fix uses the @requires tag to make sure this is the case.

Looks good! Please, don't forget to update the copyright years before 
pushing.

-JB-

>
> Best regards,
> Alexander
>



More information about the serviceability-dev mailing list