jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

Eamonn McManus eamonn at mcmanus.net
Wed Jan 6 15:18:56 UTC 2016


Looks good to me (emcmanus) too.

Éamonn

2016-01-06 7:04 GMT-08:00 Alan Bateman <Alan.Bateman at oracle.com>:

>
>
> On 06/01/2016 11:00, Jaroslav Bachorik wrote:
>
>> On 5.1.2016 16:47, Eamonn McManus wrote:
>>
>>> OK. In that case I would suggest removing the checkVersion variable
>>> since it is now always true, along with the logic from
>>> ImplVersionCommand for when it is false.
>>>
>>
>> Done. Also updated the test summary wording as suggested by Alan:
>> http://cr.openjdk.java.net/~jbachorik/8143047/webrev.01
>>
> @summary looks okay now - thanks!
>
> -Alan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160106/fef583ad/attachment-0001.html>


More information about the serviceability-dev mailing list