[ding] Re: jmx-dev [pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

[Daniel Fuchs]

Hi,

This looks OK to me.
I'm not sure I understand the full impact of the changes
in getAddressesForLocalHost() though - so hopefully someone
else will jump in to review that part...

best regards,

-- daniel

On 07/01/16 16:02, Jaroslav Bachorik wrote:
> On 5.1.2016 15:30, Jaroslav Bachorik wrote:
>> On 4.1.2016 10:05, Jaroslav Bachorik wrote:
>>> Gentle reminder ...
>>>
>>> On 23.12.2015 11:26, Jaroslav Bachorik wrote:
>>>> Please, review the following test change
>>>>
>>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8146015
>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00
>>>>
>>>> The test fails for IPv6 addresses since the RMI expects an IPv6 address
>>>> to be properly wrapped in '[]'. In addition to that the logic for
>>>> selecting IP addresses to bind is flawed - it does not check for IP
>>>> addresses of multiple adapters but for multiple IP addresses
>>>> assigned to
>>>> 'localhost'. In combination with IPv4 & IPv6 this will cause the
>>>> test to
>>>> attempt binding to IPv4 and IPv6 address of the same adapter
>>>> simultaneously and the test will fail.
>>>>
>>>> The fix adds the requested wrapping for IPv6 addresses and adjusts the
>>>> IP selection logic to iterate over distinct adapters first and prevent
>>>> IPv4 and IPv6 address of the same adapter being treated as two
>>>> addresses
>>>> (for the purposes of the test).
>>>>
>>>> Thanks,
>>>>
>>>> -JB-
>>>
>>
>