RFR: JDK-8147447: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java test fails

[Staffan Larsen]

> On 21 jan. 2016, at 15:33, Alexander Kulyakhtin <alexander.kulyakhtin at oracle.com> wrote:
> 
> Staffan,
> 
> Would it be sufficient to modify the code so that isCompMode() returns true if and only if the -Xcomp option is present and is not followed by the -Xmixed option?

Maybe, but that looks fragile. What if there is another option that implicitly enables compile mode?

> 
> Best regards,
> Alexander
> 
> ----- Original Message -----
> From: staffan.larsen at oracle.com
> To: alexander.kulyakhtin at oracle.com
> Cc: serviceability-dev at openjdk.java.net
> Sent: Thursday, January 21, 2016 5:20:14 PM GMT +03:00 Iraq
> Subject: Re: RFR: JDK-8147447: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java test fails
> 
> isCompMode() will fail if the VM is started with both -Xcomp and -Xmixed.
> 
> We need to find a better way to check if compiled mode is being used. Perhaps System.getProperty("java.vm.info").contains("compiled”) ?
> 
> /Staffan
> 
>> On 19 jan. 2016, at 11:59, Alexander Kulyakhtin <alexander.kulyakhtin at oracle.com> wrote:
>> 
>> Hi,
>> 
>> Could you, please, review this minor test-only change
>> 
>> CR: https://bugs.openjdk.java.net/browse/JDK-8147447 "[TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java test fails"
>> Webrev: http://cr.openjdk.java.net/~akulyakh/8147447/index.html
>> 
>> The test WaitNotifyThreadTest.java tries expects to find in the jstack output the string similar to:
>> 'waiting on <0x000000008f64e6d0> (a java.lang.Object)'
>> However, with the -Xcomp option turned on there is no object reference available and the same strings look like:
>> 'waiting on <no object reference available>'
>> This causes the false failures of the test when executed with the -Xcomp option.
>> 
>> We are modifying the test so it takes into account the possible difference between the jstack outputs.
>> 
>> The same issue has been present in the legacy test from which this test has been ported, so it is not a new and not a regression issue.
>> 
>> Best regards,
>> Alexander
>