RFR(S): PING! JDK-8134434: JVM_DoPrivileged() fires assert(_exception_caught == false) failed: _exception_caught is out of phase

[Lindenmaier, Goetz]

Hi Dmitry,

thanks for looking at this issue.
I think your fix will crash if thread->jvmti_thread_state();
returns NULL.  Also, please add the #include with leading
directory prims/ at the proper alphabetic position.

Also, you could add the test Richard supplied, see below.

Best regards,
  Goetz.

--- /dev/null   Thu Jan 01 00:00:00 1970 +0000                                                                               
+++ b/test/serviceability/jvmti/ExceptionCaughtOutOfPhaseAssertion.java Mon Jul 11 11:30:12 2016 +0200                       
@@ -0,0 +1,55 @@                                                                                                             
+/*                                                                                                                          
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.                                                   
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.                                                            
+ *                                                                                                                          
+ * This code is free software; you can redistribute it and/or modify it                                                     
+ * under the terms of the GNU General Public License version 2 only, as                                                     
+ * published by the Free Software Foundation.                                                                               
+ *                                                                                                                          
+ * This code is distributed in the hope that it will be useful, but WITHOUT                                                 
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or                                                    
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License                                                    
+ * version 2 for more details (a copy is included in the LICENSE file that                                                  
+ * accompanied this code).                                                                                                  
+ *                                                                                                                          
+ * You should have received a copy of the GNU General Public License version                                                
+ * 2 along with this work; if not, write to the Free Software Foundation,                                                   
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.                                                            
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+import java.security.AccessController;
+import java.security.PrivilegedAction;
+
+/*
+ * @test
+ * @bug 8134434
+ * @summary JVM_DoPrivileged() fires assert(_exception_caught == false) failed: _exception_caught is out of phase
+ * @run main/othervm -agentlib:jdwp=transport=dt_socket,address=9000,server=y,suspend=n -Xbatch ExceptionCaughtOutOfPhaseAssertion
+ */
+
+public class ExceptionCaughtOutOfPhaseAssertion {
+    public static void main(String[] args) {
+        PrivilegedAction action = new HotThrowingAction();
+        System.out.println("### Warm-up");
+        for(int i=0; i<11000; i++) {
+            try {
+                action.run(); // call run() to get it compiled
+            } catch(Throwable t) { /* ignored */ }
+        }
+        System.out.println("### Warm-up done");
+        System.out.println("### Executing privileged action");
+        try {
+            AccessController.doPrivileged(action);
+        } catch (Error e) {
+        }
+    }
+    public static class HotThrowingAction implements PrivilegedAction {
+        public Object run() {
+            throw new Error();
+        }
+    }
+}






> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> bounces at openjdk.java.net] On Behalf Of Dmitry Samersoff
> Sent: Montag, 11. Juli 2016 10:23
> To: serviceability-dev at openjdk.java.net; hotspot-runtime-dev <hotspot-
> runtime-dev at openjdk.java.net>
> Subject: RFR(S): PING! JDK-8134434: JVM_DoPrivileged() fires
> assert(_exception_caught == false) failed: _exception_caught is out of phase
> 
> PING ...
> 
> 
> -------- Forwarded Message --------
> Subject: RFR(S): JDK-8134434: JVM_DoPrivileged() fires
> assert(_exception_caught == false) failed: _exception_caught is out of phase
> Date: Wed, 6 Jul 2016 19:24:15 +0300
> From: Dmitry Samersoff <dmitry.samersoff at oracle.com>
> To: serviceability-dev at openjdk.java.net
> <serviceability-dev at openjdk.java.net>
> 
> Everybody,
> 
> Please review the fix.
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8134434/webrev.01/
> 
> All credentials belongs to Richard Reingruber, see mail thread (below)
> for details.
> 
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-
> August/019613.html
> 
> 
> -Dmitry
> 
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
> 
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.