RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

[David Holmes]

On 9/06/2016 10:33 AM, David Holmes wrote:
> Hi Kirill,
>
> On 9/06/2016 4:26 AM, Kirill Zhaldybin wrote:
>> Dear all,
>>
>> After discussion with Mandy Chung, Daniel Fuchs and Frederic Parain we
>> decided to provide separate error message for the case if method exists
>> but signature or parametes are wrong but throw the same
>> NoSuchMethodError exception.
>>
>> Could you please review this fix for 8156226?
>>
>> New WebRev:
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.04/
>
> As I said previously I have doubts about the entire block of code as the
> checking is not comprehensive.
>
> That aside an augmented message seems a good improvement but I'm wondering:
>
> a) how does it look (not sure what Arrays.toString(signature) will print) ?
> b) why do we not report what may be wrong with params?

Ignore that. Without doing full element by element checking of signature 
and params you can't give an accurate error message. What is there is 
better than nothing.

Thanks,
David

> Thanks,
> David
> -----
>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8156226
>>
>> Thank you.
>>
>> Regards, Kirill
>>
>> On 06.05.2016 20:16, Kirill Zhaldybin wrote:
>>> Dear all,
>>>
>>> Could you please review this small fix for 8156226?
>>>
>>> A case when a method exists but parameters' signature is wrong now
>>> causes new ReflectionException(new IllegalArgumentException()) thrown
>>> instead of new ReflectionException(new NoSuchMethodException()).
>>>
>>> WebRev:
>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.00/
>>>
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8156226
>>>
>>> Thank you.
>>>
>>> Regards, Kirill
>>