RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Thu Jun 9 12:09:59 UTC 2016


Mandy,

Thank you for reviewing the fix!

I added signature to another error message as you advised.
Here are a new WebRev: 
http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.05/

Could you please let me know your opinion?

Regards, Kirill

On 08.06.2016 21:25, Mandy Chung wrote:
>
>> On Jun 8, 2016, at 11:26 AM, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
>>
>> Dear all,
>>
>> After discussion with Mandy Chung, Daniel Fuchs and Frederic Parain we decided to provide separate error message for the case if method exists but signature or parametes are wrong but throw the same NoSuchMethodError exception.
>>
>> Could you please review this fix for 8156226?
>>
>> New WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8156226/webrev.04/
>
> This looks okay.  It’d be useful for the case line 269 to include the signature as well.
>
> Mandy
>



More information about the serviceability-dev mailing list