Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

[serguei.spitsyn at oracle.com]

On 6/22/16 10:45, Alan Bateman wrote:
>
>
> On 22/06/2016 18:09, stanislav lukyanov wrote:
>> Hi Serguei,
>>
>> What is the expected behavior when passed string is not a valid 
>> package name (e.g. contains illegal characters)?
>> I think I'd expect JVMTI_ERROR_ILLEGAL_ARGUMENT to be returned in 
>> that case.
>>
>> Now it looks like the method will return unnamed module not only for 
>> an empty string
>> but for any string that is not a known package name.
>> If it's correct, I think the empty string case shouldn't be described 
>> explicitly.
> The empty string is the unnamed module case and so the function should 
> always return the unamed module.
>
> You question on whether this function checks for invalid identifiers 
> is a good question as that is currently not specified.

I'd suggest to specify this function does not check for invalid 
characters (or identifiers).
Please, let me know if you have objections.

Thanks,
Serguei


>
> -Alan