RFR (XS): 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Mar 2 18:26:00 UTC 2016


Looks good for me!

On 2016-03-02 19:56, Andreas Eriksson wrote:
> Hi,
> 
> Can I please have a review for this small test fix.
> 
> Bug: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
> failing because expects HPROF JAVA PROFILE 1.0.1 file format
> https://bugs.openjdk.java.net/browse/JDK-8150986
> Webrev: http://cr.openjdk.java.net/~aeriksso/8150986/webrev/
> 
> As part of JDK-8144732
> <https://bugs.openjdk.java.net/browse/JDK-8144732> support for dumping
> hprof with format 1.0.1 was removed, and we use format 1.0.2 always.
> I missed updating this test, which checks the header string in a heap dump.
> 
> Thanks,
> Andreas


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list