RFR[9u-dev]: 8151509: In check_addr0() function pointer is not updated correctly

[Dmitry Dmitriev]

Hi Cheleswer,

Looks good, but I have questions/comments about other code in this function:
1) I think that "::close(fd);" should be inside "if (fd >= 0) {".
2) Just interesting, do you really need to set memory to 0 by memset?

Thanks,
Dmitry


On 10.03.2016 13:43, Cheleswer Sahu wrote:
>
> Hi,
>
> Please review the code changes for 
> https://bugs.openjdk.java.net/browse/JDK-8151509.
>
> Webrev link: http://cr.openjdk.java.net/~csahu/8151509/ 
> <http://cr.openjdk.java.net/%7Ecsahu/8151509/>
>
> Bug Brief:
>
> In check_addr0(),  pointer ”p” is not updated correctly, because of 
> this it was reading only first two entries from buffer.
>
> Regards,
>
> Cheleswer
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160310/1d181fad/attachment.html>