RFR (S): 8137165: Tests fail in SR_Handler because thread is not VMThread or JavaThread

[David Holmes]

Hi Kim,

On 15/03/2016 4:34 PM, Kim Barrett wrote:
>> On Mar 14, 2016, at 2:46 AM, David Holmes <david.holmes at oracle.com> wrote:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8137165
>> Webrev: http://cr.openjdk.java.net/~dholmes/8137165/webrev/
>>
>> This isn't a fix per-se but some additional diagnostic code to try and detect the conditions where the bug might manifest. The basic failure mode was:
>
> Changes look good.
>
> Good cleanup with the sigemptyset calls.  Pedantic is a good thing when dealing with POSIX.

Thanks for the Review.

> Since this isn’t an actual fix, should the change be associated with a different bug number?
> Or are you treating this as the moral equivalent of resolving as not reproducible?

I toyed with creating a subtask for this change and leaving the original 
open, but realistically I think it may turn out to be "not 
reproducible". I can be swayed if you think a new subtask would be better?

Thanks,
David