RFR: 8150823: UL handles disabling logs incorrectly

Marcus Larsson marcus.larsson at oracle.com
Fri Mar 18 11:25:20 UTC 2016


Hi,

Updated the patch after offline discussion. New patch attempts to 
normalize the output name before searching for it or adding it. This 
includes adding the implicit file= prefix if missing, and/or removing 
quotes from a quoted name.

Webrev:
http://cr.openjdk.java.net/~mlarsson/8150823/webrev.01/

Incremental:
http://cr.openjdk.java.net/~mlarsson/8150823/webrev.00-01/

Tested with serviceability/logging tests through RBT.

Thanks,
Marcus

On 03/11/2016 03:40 PM, Marcus Larsson wrote:
> Hi,
>
> Please review the following patch to fix a problem with disabling log 
> outputs using -Xlog:disable or disable_logging() when there are 
> multiple file outputs configured. The patch also resolves an issue 
> with log file lookups that could cause multiple outputs to be created 
> for the same log file.
>
> Log output removal now iterates backwards to not invalidate the loop 
> index, and file outputs are always prepended with "file=" during 
> lookups and listings.
>
> Webrev:
> http://cr.openjdk.java.net/~mlarsson/8150823/webrev.00/
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8150823
>
> Testing:
> Included tests through RBT
>
> Thanks,
> Marcus



More information about the serviceability-dev mailing list