RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp (v4)

[Robbin Ehn]

Hi Stefan

On 03/23/2016 03:27 PM, Stefan Karlsson wrote:
> Hi Robbin,
>
> On 2016-03-23 14:50, Robbin Ehn wrote:
>> Hi all,
>>
>> After more input, this is the current version.
>> Please have a look.
>>
>> Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/
>> Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/
>
> Looks good to me.
>
> It's non-obvious why you change the "stderr" config below, so that might
> warrant a comment:
>
>     LogConfiguration::disable_logging();
>     assert(Test_logconfiguration_subscribe_triggered == 3, "subscription
> not triggered (3)");
>
> - // Restore saved configuration
> - LogConfiguration::parse_log_arguments("stdout", saved_config, NULL,
> NULL, log.error_stream());
> - os::free(saved_config);

I'll add comment!

(The reason is that LogConfiguration::disable_logging will disable both 
stdout and stderr,
the TestLogSavedConfig will restore stdout for us but not stderr.)

Thanks Stefan!

/Robbin

> + LogConfiguration::parse_log_arguments("stderr", "all=warning", NULL,
> NULL, log.error_stream());
> + assert(Test_logconfiguration_subscribe_triggered == 4, "subscription
> not triggered (3)");
>   }
>
> Thanks,
> StefanK
>
>
>
>>
>> Thanks!
>>
>> /Robbin
>>
>> On 03/21/2016 05:34 PM, Robbin Ehn wrote:
>>> Hi all, please review this a somewhat bigger change-set.
>>>
>>> Updated with the feedback.
>>>
>>> New webrev: http://cr.openjdk.java.net/~rehn/8151993/v2/webrev/
>>>
>>> Tested with jprt hotspot and I added 2 internal vm tests.
>>>
>>> (also 2 bugs fixed, missing va_end and a potential race when calling
>>> prefix function twice (very unlikely))
>>>
>>> Thanks!
>>>
>>> /Robbin
>>>
>>> On 03/16/2016 01:33 PM, Robbin Ehn wrote:
>>>> Hi, please review this small change.
>>>>
>>>> This also change allocation methods.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8151993/
>>>> Webrev: http://cr.openjdk.java.net/~rehn/8151993/webrev/
>>>>
>>>> Thanks!
>>>>
>>>> /Robbin
>