RFR(S) JDK-8150973 Hotspot agent use of sun.boot.class.path needs to be updated for Jigsaw

Dmitry Samersoff dmitry.samersoff at oracle.com
Mon Mar 28 19:35:00 UTC 2016


Alan,

> Shouldn't VirtualMachineImpl.bootClassPath return emptyList() rather
> than throw an implementation specific exception?

This function never used anymore. So I would prefer an exception to make
any attempt to call it fails immediately.

Would RuntimeException better?

-Dmitry

On 2016-03-28 22:28, Alan Bateman wrote:
> 
> 
> On 28/03/2016 19:15, Dmitry Samersoff wrote:
>> Everybody,
>>
>> Please review:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/
>>
>> All references to boot class path in SA code is removed.
>>
>> VirtualMachineImpl.bootClassPath() is the part of
>> sun.com.jdi.PathSearchingVirtualMachine interface,
>> cleanup of this interface requires much more efforts,
>> so I file a separate CR for this work.
>>
>> src/jdk.hotspot.agent/test/jdi/runsa.sh is part of obsoleted tests,
>> cleanup of this tests is in progress under a separate CR.
>>
> Shouldn't VirtualMachineImpl.bootClassPath return emptyList() rather
> than throw an implementation specific exception?
> 
> -Alan


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list