RFR:8153978:New test to verify the modules info as returned by the JVMTI

[serguei.spitsyn at oracle.com]

Hi Alexander,

It looks good.
Thank you for making the changes!

Thanks,
Serguei



On 5/4/16 05:17, Alexander Kulyakhtin wrote:
> Hi Sergey,
>
> Thank you very much for the review.
>
> Please, find the updated webrev with your findings corrected at:
> http://cr.openjdk.java.net/~akulyakh/8153978_02/index.html
>
> Best regards,
> Alexander
>
> ----- Original Message -----
> From: serguei.spitsyn at oracle.com
> To: alexander.kulyakhtin at oracle.com, serviceability-dev at openjdk.java.net
> Cc: aleksey.voytilov at oracle.com
> Sent: Tuesday, May 3, 2016 1:06:05 AM GMT +03:00 Iraq
> Subject: Re: RFR:8153978:New test to verify the modules info as 
> returned by the JVMTI
>
> Hi Alexander,
>
>
> Could you, fix a couple of minor issues?
>
> test/serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java
>    58         for(Module mod : my.modules()) {
>    59             if(!jvmtiModules.contains(mod)) {
>
>    A space is missed after the 'for' and 'if' keywords.
>
> test/serviceability/jvmti/GetModulesInfo/ModulesInfo.java.
>    31     boolean compareExcludingUnnamed(ModulesInfo other) {
>
>    I'd suggest to call it compareNamed.
>
> Otherwise, the new test looks great.
> Thanks a lot for taking care about it!
>
> Thanks,
> Serguei
>
>
>
> On 4/29/16 06:12, Alexander Kulyakhtin wrote:
>
>     Hi,
>
>     Could you, please, review these test-only changes (adding a new test).
>
>     CR:https://bugs.openjdk.java.net/browse/JDK-8153978  "New test to verify the modules info as returned by the JVMTI"
>     Webrev:http://cr.openjdk.java.net/~akulyakh/8153978_01/
>
>     The new test verifies that JVMTI returns the correct info about the modules loaded at the application startup.
>     It also verifies that the returned info is consistent with the same info returned by the Java API.
>     It then loads a new named module and checks the correctness of the JVMTI info again.
>
>     Due to a tools issuehttps://bugs.openjdk.java.net/browse/CODETOOLS-7901662  the test can only be pushed in when the updated jtreg is released.
>     The test passes fine with the nightly jtreg build, containing the CODETOOLS-7901662 fix.
>
>     Best regards,
>     Alexander
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160504/7a96a9e8/attachment-0001.html>