RFR (XS): 8157188: 2 test failures in demo/jvmti due to unexpected class file version 53
Dmitry Samersoff
dmitry.samersoff at oracle.com
Thu May 19 05:01:25 UTC 2016
David,
Looks good for me.
Probably I was the last person who do something with java_crw_demo.c.
-Dmitry
On 2016-05-19 07:52, David Holmes wrote:
> Not sure who really owns this file so cc'ing core-libs and serviceability.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8157188
>
> The file src/java.base/share/native/include/classfile_constants.h
> describes information about classfiles and is used by libverify and
> ./demo/share/jvmti/java_crw_demo/java_crw_demo.c
>
> This file has not been updated for classfile version 53 and so asserts
> will fail in java_crw_demo.c when it encounters classes compiled for
> version 53 - as they now are. This version change caused test failures
> in the hotspot forest when it was pulled down earlier this week.
>
> This fix trivially bumps the current version number to 53 to fix the
> failing tests. It is a separate issue as to whether other changes are
> needed in this file to reflect what is new with classfile version 53.
>
> Diff below.
>
> Thanks,
> David
> ------
>
> diff -r 3eea6819cc1f
> src/java.base/share/native/include/classfile_constants.h
> --- a/src/java.base/share/native/include/classfile_constants.h
> +++ b/src/java.base/share/native/include/classfile_constants.h
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights
> reserved.
> + * Copyright (c) 2004, 2016, Oracle and/or its affiliates. All rights
> reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
> * This code is free software; you can redistribute it and/or modify it
> @@ -31,7 +31,7 @@
> #endif
>
> /* Classfile version number for this information */
> -#define JVM_CLASSFILE_MAJOR_VERSION 52
> +#define JVM_CLASSFILE_MAJOR_VERSION 53
> #define JVM_CLASSFILE_MINOR_VERSION 0
>
> /* Flags */
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the serviceability-dev
mailing list