RFR: 8157555 com/sun/jdi/RedefineClearBreakpoint.sh times out due to Indify String Concat being slow in debug mode

[Dmitry Samersoff]

Staffan,

> Yes, that would have been a little better. Unfortunately I have
> already pushed the change. Let me know if you think it is important
> enough to fix.

No, it's not so important. Sorry for being later.

-Dmitry

On 2016-05-24 12:00, Staffan Larsen wrote:
> Yes, that would have been a little better. Unfortunately I have
> already pushed the change. Let me know if you think it is important
> enough to fix.
> 
> /Staffan
> 
>> On 24 maj 2016, at 10:42, Dmitry Samersoff
>> <dmitry.samersoff at oracle.com> wrote:
>> 
>> Staffan,
>> 
>> 37: It's better to write it as:
>> 
>> timeout_factor=`echo $TESTTIMEOUTFACTOR | awk '{printf "%3.0f\n",
>> $1}'`
>> 
>> It uses the same synax as the rest of script and round value rather
>> than truncate it.
>> 
>> -Dmitry
>> 
>> On 2016-05-23 12:17, Staffan Larsen wrote:
>>> This is my second attempt at fixing this timeout by taking the
>>> jtreg timeout factor into account in the tests. The first fix [1]
>>> looked at the wrong environment variable, and also would have
>>> caused the test to run unnecessarily slow since it set
>>> sleep_seconds to a higher value instead of changing the timeout.
>>> 
>>> In this version I have tried to fix these problems. I now look at
>>> the env variable TESTTIMEOUTFACTOR which will contain the jtreg
>>> timeout factor in floating point notation. Since it is easier to
>>> work with integers in shell scripts, I truncate this value using
>>> and awk expression. I then use this value to set up time limits
>>> in the two places where we have them. To simplify the code in the
>>> cmd() function, I no longer print out stack traces after half the
>>> timeLimit, only when the limit has expired. I think this is
>>> reasonable.
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8157555 webrev:
>>> http://cr.openjdk.java.net/~sla/8157555/webrev.00/
>>> 
>>> Thanks, /Staffan
>>> 
>>> [1] http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/5a553039e9fc
>> 
>> 
>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg,
>> Russia * I would love to change the world, but they won't give me
>> the sources.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.