RFR: JDK-7107013: sun.jvm.hotspot.runtime.Bytes.swapLong conversion to long mishandled

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Nov 9 19:16:00 UTC 2016


Sharath,

Please, add (int) to ll. 54 for better readability.

PS:

Despite the fact that C2 does a great job eliminating useless code
(multiple calls to if (!swap) in this case) it would be nice to use
simple, well known arithmetic directly instead of subsequent calls to
other swap functions.

-Dmitry

On 2016-11-09 19:30, Sharath Ballal wrote:
> Hello,
> 
> Pls review this small fix
> 
>  
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-7107013
> 
> Webrev: http://cr.openjdk.java.net/~sballal/7107013/webrev.00/
> 
>  
> 
>  
> 
> -Sharath Ballal
> 
>  
> 
>  
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list