RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Harsha Wardhana B
harsha.wardhana.b at oracle.com
Fri Nov 18 15:43:25 UTC 2016
Hello,
Please review below webrev incorporating Roger's comment.
http://cr.openjdk.java.net/~hb/8169575/webrev.01/
-Harsha
On Friday 18 November 2016 09:08 PM, Frederic Parain wrote:
> "exitVM.*" should be fine to avoid future maintenance burden.
> Thank you for pointing this out Roger.
>
> Fred
>
> On 11/18/2016 10:32 AM, Harsha Wardhana B wrote:
>> Hi Roger,
>>
>> I was not sure about adding exitVM.* as that would give permissions for
>> all exit codes.
>>
>> Maybe Fred can comment since he is the test case author.
>>
>> -Harsha
>>
>>
>> On Friday 18 November 2016 08:58 PM, Roger Riggs wrote:
>>> Hi Harsha,
>>>
>>> The addition of the permission for
>>> "getProperty.jdk.jar.disabledAlgorithms" is fine.
>>>
>>> But the addition of a permission for exitVM.95 to satisfy the need of
>>> the test harness to exit cleanly
>>> should instead be fixed by changing the "exitVM.97" to "exitVM.*" to
>>> avoid future maintenance
>>> in the case where the test harness changes its exit status.
>>>
>>> Roger
>>>
>>>
>>> On 11/18/2016 4:47 AM, Harsha Wardhana B wrote:
>>>> Hello All,
>>>>
>>>> Please review below fix for issue
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8169575
>>>>
>>>> having webrev at,
>>>>
>>>> http://cr.openjdk.java.net/~hb/8169575/webrev.00/
>>>>
>>>> Regards
>>>>
>>>> Harsha
>>>>
>>>
>>
More information about the serviceability-dev
mailing list