RFR: JDK-8165765: javax/management/remote/mandatory/connection/RMIConnectionIdTest.java: failed when looking at RMI connection IDs:
Ujwal Vangapally
ujwal.vangapally at oracle.com
Thu Nov 24 08:20:00 UTC 2016
Thanks for the review Roger, please find the new webrev incorporating
the review comments.
webrev :http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.01/
-Ujwal
On 11/23/2016 10:10 PM, Roger Riggs wrote:
> Hi,
>
> RMIConnectionIdTest.java:
>
> - The method NetworkInterface.getByInetAddress(addr) may be a better
> choice
> without all the looping and repetitive checks of localAddr == null.
>
> Roger
>
> p.s.
>
> This would have been a good use of streams with
> NetworkInterface.networkInterfaces
> and NetworkInterface.inetAddresses.
>
>
> On 11/23/2016 4:08 AM, Ujwal Vangapally wrote:
>> Please review this small change for the bug below
>>
>> https://bugs.openjdk.java.net/browse/JDK-8165765
>>
>> Webrev: http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.00/
>>
>> Thanks,
>>
>> Ujwal.
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20161124/7be8f0c5/attachment.html>
More information about the serviceability-dev
mailing list