RFR: JDK-8165765: javax/management/remote/mandatory/connection/RMIConnectionIdTest.java: failed when looking at RMI connection IDs:

[Roger Riggs]

Hi Ujwal,

looks fine.

Have you been able to verify the test on a system similar to where it 
failed originally?

Thanks, Roger



On 11/27/2016 11:47 PM, Ujwal Vangapally wrote:
>
> gentle reminder
>
> Thanks,
>
> Ujwal
>
>
> On 11/24/2016 1:50 PM, Ujwal Vangapally wrote:
>>
>> Thanks for the review Roger, please find the new webrev incorporating 
>> the review comments.
>>
>> webrev :http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.01/
>>
>> -Ujwal
>>
>> On 11/23/2016 10:10 PM, Roger Riggs wrote:
>>> Hi,
>>>
>>> RMIConnectionIdTest.java:
>>>
>>>  - The method NetworkInterface.getByInetAddress(addr) may be a 
>>> better choice
>>>    without all the looping and repetitive checks of localAddr == null.
>>>
>>> Roger
>>>
>>> p.s.
>>>
>>> This would have been a good use of streams with 
>>> NetworkInterface.networkInterfaces
>>>    and NetworkInterface.inetAddresses.
>>>
>>>
>>> On 11/23/2016 4:08 AM, Ujwal Vangapally wrote:
>>>> Please review this small change for the bug below
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8165765
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~hb/sponsorship/8165765/webrev.00/
>>>>
>>>> Thanks,
>>>>
>>>> Ujwal.
>>>>
>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20161128/60d362bf/attachment.html>