RFR: 8164383: jhsdb dumps core on Solaris 12 when loading dumped core

[Jini Susan George]

Could I get a second review for this, please ?

 

Thanks,

Jini.

 

From: Serguei Spitsyn 
Sent: Monday, October 03, 2016 10:22 AM
To: Jini Susan George; serviceability-dev
Subject: Re: RFR: 8164383: jhsdb dumps core on Solaris 12 when loading dumped core

 

Ok.

Thanks, Jini.
Serguei

On 10/2/16 20:49, Jini Susan George wrote:

Thank you very much, Serguei, for the quick review. Yes, the crashes were since the last arguments were not passed to Plookup_by_addr() and proc_arg_grab(). For JDK9, SOLARIS_11_B159_OR_LATER does not serve any purpose. -D SOLARIS_11_B159_OR_LATER was being passed unconditionally in make/lib/Lib-jdk.hotspot.agent.gmk. 

 

Thanks,

Jini.

 

From: Serguei Spitsyn 
Sent: Monday, October 03, 2016 8:50 AM
To: Jini Susan George; serviceability-dev
Subject: Re: RFR: 8164383: jhsdb dumps core on Solaris 12 when loading dumped core

 

On 10/2/16 19:39, HYPERLINK "mailto:serguei.spitsyn at oracle.com"serguei.spitsyn at oracle.com wrote:

Hi Jini,

It looks good to me.
What is the root cause of this crash?
Is it because the 6th argument was not passed to the Plookup_by_addr() ?
Also, could you explain why the code under SOLARIS_11_B159_OR_LATER is being removed?
Is it not needed anymore?

Ok, I've found the answer about SOLARIS_11_B159_OR_LATER in the bug report.

Thanks,
Serguei




Thanks,
Serguei


On 10/2/16 09:56, Jini Susan George wrote:

Could I please get reviews done for the following fix? 

 

Bug ID: https://bugs.openjdk.java.net/browse/JDK-8164383

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Ejgeorge/8164383/webrev.00/"http://cr.openjdk.java.net/~jgeorge/8164383/webrev.00/

 

Thanks,

- Jini Susan George

 

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20161003/f63a4694/attachment.html>