RFR: 8166289: RuntimeException: canRead() reports false for reading from the same module: expected true, was false

[Alexander Kulyakhtin]

Hi Sergey,

Thank you very much for the review.

Best regards,
Alexander

----- Original Message -----
From: serguei.spitsyn at oracle.com
To: alexander.kulyakhtin at oracle.com, serviceability-dev at openjdk.java.net
Sent: Tuesday, October 18, 2016 10:31:40 AM GMT +03:00 Iraq
Subject: Re: RFR: 8166289: RuntimeException: canRead() reports false for reading from the same module: expected true, was false

Hi Alexander,

The fix looks good to me.
In a case the bug is reproduced again we will have some details (module 
name and ID) to understand what is wrong.

Thanks,
Serguei



On 10/17/16 06:08, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review these test-only changes
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8166289 "RuntimeException: canRead() reports false for reading from the same module: expected true, was false"
> Webrev: http://cr.openjdk.java.net/~akulyakh/8166289/
>
> The fix restores the changes for https://bugs.openjdk.java.net/browse/JDK-8165017, which were backed out with https://bugs.openjdk.java.net/browse/JDK-8166312, due to the test failure.
> The test failure have never been reproduced after extensive testing. This fix is trying to restore the changes adding a more correct verification of the CANREAD command, as well as some additional logging in case the test fails again.
>
> Best regards,
> Alexander
>