RFR: 8164501: Uninitialised memory in byteArrayToPacket of SharedMemoryConnection.c

[Dmitry Samersoff]

Robbin,

Looks good for me.

Please, fix comment

* The length of the JDWP packet is 11 + data
to
* The length of the JDWP packet is sizeof(pktHeader) + data

-Dmitry


On 2016-10-21 15:01, Robbin Ehn wrote:
> Hi again.
> 
> Correct http webrev location should be:
> http://cr.openjdk.java.net/~rehn/8164501/01/webrev/
> http://cr.openjdk.java.net/~rehn/8164501/01_inc/webrev/
> 
> /Robbin
> 
> On 10/21/2016 01:11 PM, Robbin Ehn wrote:
>> Hi Staffan, thanks for having a look.
>>
>> On 10/21/2016 11:28 AM, Staffan Larsen wrote:
>>> Can you change:
>>>
>>> 185     if (total_length < 11) {
>>>
>>> to
>>>
>>> 185     if (total_length < sizeof(pktHeader) {
>>>
>>> ?
>>
>> Yes, I'll then propose changing all 11 to sizeof(pktHeader).
>>
>> Full: http://rehn-ws.se.oracle.com/cr_mirror/8164501/01/webrev/
>> Inc: http://rehn-ws.se.oracle.com/cr_mirror/8164501/01_inc/webrev/
>>
>> /Robbin
>>
>>>
>>>> On 21 Oct 2016, at 09:41, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>>>>
>>>> Hi all, please review!
>>>>
>>>> This patch makes sure pktHeader is not used uninitialized and that
>>>> total_length is at least 11.
>>>> The bug is confidential, but subject and patch says alot.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8164501
>>>> Webrev: http://cr.openjdk.java.net/~rehn/8164501/webrev/
>>>>
>>>> Thanks!
>>>>
>>>> /Robbin
>>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.