RFR: 8164501: Uninitialised memory in byteArrayToPacket of SharedMemoryConnection.c
Staffan Larsen
staffan.larsen at oracle.com
Fri Oct 21 13:20:45 UTC 2016
Looks good!
Thanks,
/Staffan
> On 21 Oct 2016, at 14:01, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>
> Hi again.
>
> Correct http webrev location should be:
> http://cr.openjdk.java.net/~rehn/8164501/01/webrev/
> http://cr.openjdk.java.net/~rehn/8164501/01_inc/webrev/
>
> /Robbin
>
> On 10/21/2016 01:11 PM, Robbin Ehn wrote:
>> Hi Staffan, thanks for having a look.
>>
>> On 10/21/2016 11:28 AM, Staffan Larsen wrote:
>>> Can you change:
>>>
>>> 185 if (total_length < 11) {
>>>
>>> to
>>>
>>> 185 if (total_length < sizeof(pktHeader) {
>>>
>>> ?
>>
>> Yes, I'll then propose changing all 11 to sizeof(pktHeader).
>>
>> Full: http://rehn-ws.se.oracle.com/cr_mirror/8164501/01/webrev/
>> Inc: http://rehn-ws.se.oracle.com/cr_mirror/8164501/01_inc/webrev/
>>
>> /Robbin
>>
>>>
>>>> On 21 Oct 2016, at 09:41, Robbin Ehn <robbin.ehn at oracle.com> wrote:
>>>>
>>>> Hi all, please review!
>>>>
>>>> This patch makes sure pktHeader is not used uninitialized and that total_length is at least 11.
>>>> The bug is confidential, but subject and patch says alot.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8164501
>>>> Webrev: http://cr.openjdk.java.net/~rehn/8164501/webrev/
>>>>
>>>> Thanks!
>>>>
>>>> /Robbin
>>>
More information about the serviceability-dev
mailing list