RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

Mandy Chung mandy.chung at oracle.com
Mon Oct 24 21:53:39 UTC 2016


> On Oct 24, 2016, at 5:49 AM, Amit Sapre <amit.sapre at oracle.com> wrote:
> 
> Hello,
> 
> I have incorporate review comments and updated changes are available in this webrev:
> Updated Webrev : http://cr.openjdk.java.net/~asapre/webrev/8151099/webrev.01/ 
> 

Looks okay to me.

sun/management/VMManagementImpl.java
 106         try {
 107             Class.forName("com.sun.management.GarbageCollectorMXBean");
 108         } catch (Exception x) {

==> catch specific exception would be better e.g. ClassNotFoundException

 109           isSupported = false;

Nit: 4-space indent

jdk/test/com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationContentTest.java
  75         final Boolean isNotificationSupported = 
test/com/sun/management/GarbageCollectorMXBean/GarbageCollectionNotificationTest.java
  74         final Boolean isNotificationSupported =

It can use “boolean” primitive type.

DefaultManagementProviderTest.java
  Can you break the long @summary line

Mandy


More information about the serviceability-dev mailing list