PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

Amit Sapre amit.sapre at oracle.com
Fri Sep 2 06:58:17 UTC 2016


Thanks Alan for pointing this out. Incorporated your comments in this webrev

 

http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.01/ 

 

Thanks,

Amit

 

From: Alan Bateman 
Sent: Thursday, September 01, 2016 1:46 PM
To: Amit Sapre; serviceability-dev
Subject: Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

 

 

 

On 01/09/2016 07:01, Amit Sapre wrote:

Gentle reminder !                           





 

Bug Id : https://bugs.openjdk.java.net/browse/JDK-8164730 

Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejgeorge/sponsorships/8164730/webrev.00/"http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.00/ 

 

Looks okay to me. A minor comment on the test is that innerClass should be Class<?> to avoid the raw type.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160902/e035dd23/attachment-0001.html>


More information about the serviceability-dev mailing list