RFR: JDK-8165114: stale reference to hotspot test Test8028623.java

[Christian Tornqvist]

Do we still need the compact groups? I thought the @modules selection in
jtreg will make sure that we don't run tests where the module isn't
available.

-----Original Message-----
From: serviceability-dev
[mailto:serviceability-dev-bounces at openjdk.java.net] On Behalf Of David
Holmes
Sent: Friday, September 2, 2016 4:46 AM
To: Sharath Ballal <sharath.ballal at oracle.com>;
serviceability-dev at openjdk.java.net
Subject: Re: RFR: JDK-8165114: stale reference to hotspot test
Test8028623.java

On 2/09/2016 5:47 PM, Sharath Ballal wrote:
> Hi David,
> I had a similar doubt and checked with Christian Tornqvist regarding 
> the
same.  He mentioned that the directory containing the new test is already
part of two test groups, hence I need not add anything for the new test.
>
> The sun/tools folder is part of two test groups:
>
> jdk_launcher = \
>     tools/launcher \
>     sun/tools
>
> svc_tools = \
>     com/sun/tools/attach \
>     sun/tools \
>     -sun/tools/java \
>     -sun/tools/jrunscript \
>     sun/jvmstat \
>     demo/jvmti

The test needs to remain in the needs_compact3 group, neither of the above
groups contribute to that.

David
-----

>
> -Sharath Ballal
>
>
>
> -----Original Message-----
> From: David Holmes
> Sent: Friday, September 02, 2016 1:07 PM
> To: Sharath Ballal; serviceability-dev at openjdk.java.net
> Subject: Re: RFR: JDK-8165114: stale reference to hotspot test
Test8028623.java
>
> Hi Sharath,
>
> On 1/09/2016 6:00 PM, Sharath Ballal wrote:
>> Hello,
>>
>> Please review this fix to remove stale test reference:
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8165114
>>
>> Webrev: http://cr.openjdk.java.net/~sballal/8165114/webrev.00/
>
> If the test has moved then the entry has to move from
hotspot/test/TEST.groups to jdk/test/TEST.groups.
>
> Thanks,
> David
>
>>
>>
>> -Sharath Ballal
>>
>>
>>
>>
>>