RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

[serguei.spitsyn at oracle.com]

Hi Alexander,

This looks good.

There is a confusion with the CR header.
Should you get rid of the " and -Dcom.sun.management" part in it?

Thanks,
Serguei


On 9/9/16 05:07, Alexander Kulyakhtin wrote:
> Hi Mandy,
>
> Thank you very much for the review. I have added @modules java.instrument, making no other changes.
> Please, find the updated webrev at http://cr.openjdk.java.net/~akulyakh/8139368_04/
>
> Best regards,
> Alexander
>
>
> ----- Original Message -----
> From: mandy.chung at oracle.com
> To: alexander.kulyakhtin at oracle.com
> Cc: serguei.spitsyn at oracle.com, serviceability-dev at openjdk.java.net
> Sent: Friday, September 9, 2016 12:28:30 AM GMT +03:00 Iraq
> Subject: Re: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve
>
>
>> On Sep 8, 2016, at 6:28 AM, Alexander Kulyakhtin <alexander.kulyakhtin at oracle.com> wrote:
>>
>> Hi,
>>
>> Could you, please, review this test-only change (adding a new test).
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8139368 "-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve"
>> Webrev: http://cr.openjdk.java.net/~akulyakh/8139368_03/
>
> This test needs @modules java.instrument.  If it’s run on an image without java.instrument, this will fail.
>
> Otherwise looks fine.
> Mandy