RFR: 8027920: SA: Add default methods to InstanceKlass

[Ioi Lam]

Hi Jini,

The SA changes look good. The only nit -- the 3-space indentation on 
line 343 should be changed to 2-space.

  342     if (defaultMethods != null) {
  343        Address addr = defaultMethods.getValue(getAddress());

The header in the test case can be simplified:

*** test/serviceability/sa/TestDefaultMethods.java.jini 2016-09-11 
01:16:05.362254996 -0700
--- test/serviceability/sa/TestDefaultMethods.java 2016-09-11 
01:18:29.407783911 -0700
***************
*** 41,59 ****
    * @library /test/lib
    * @requires os.family != "mac"
    * @modules java.base/jdk.internal.misc
!  * @compile -XDignore.symbol.file=true
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot=ALL-UNNAMED
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot.utilities=ALL-UNNAMED
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot.oops=ALL-UNNAMED
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot.debugger=ALL-UNNAMED
!  *          TestDefaultMethods.java
!  * @run main/othervm
!  *          --add-modules=jdk.hotspot.agent
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot=ALL-UNNAMED
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot.utilities=ALL-UNNAMED
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot.oops=ALL-UNNAMED
!  * --add-exports=jdk.hotspot.agent/sun.jvm.hotspot.debugger=ALL-UNNAMED
!  *          TestDefaultMethods
    */

   interface Language {
--- 41,51 ----
    * @library /test/lib
    * @requires os.family != "mac"
    * @modules java.base/jdk.internal.misc
!  *          jdk.hotspot.agent/sun.jvm.hotspot
!  *          jdk.hotspot.agent/sun.jvm.hotspot.utilities
!  *          jdk.hotspot.agent/sun.jvm.hotspot.oops
!  *          jdk.hotspot.agent/sun.jvm.hotspot.debugger
!  * @run main/othervm TestDefaultMethods
    */

   interface Language {

Thanks!
- Ioi


On 9/10/16 11:01 PM, Jini Susan George wrote:
>
> Hello,
>
> Could I please get a review for the following fix ?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8027920
>
> Webrev: http://cr.openjdk.java.net/~jgeorge/8027920/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejgeorge/8027920/webrev.00/>
>
> Thanks,
>
> - Jini Susan George
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160911/395f7147/attachment.html>