RFR: JDK-8165493: SA: Add method in GrowableArray.java to be able to access the 'data' field

David Holmes david.holmes at oracle.com
Mon Sep 12 01:42:10 UTC 2016


Hi Poonam,

On 10/09/2016 12:52 AM, Erik Gahlin wrote:
> Could you change to:
>
> return dataField.getValue(getAddress());

Not sure if the temporary allows easier setting of breakpoints?

> Otherwise it looks good. No need to upload new webrev. Not a (R)eviewer.

But Reviewed either way.

Thanks,
David

> Thanks
> Erik
>
> On 2016-09-08 23:40, Poonam Bajaj Parhar wrote:
>> Hello,
>>
>> Please review this small change that adds an accessor method to
>> GrowableArray class for its 'data' field.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8165493
>> Webrev: http://cr.openjdk.java.net/~poonam/8165493/webrev/
>>
>> This change is required for closed flight recorder related changes on
>> the SA side.
>>
>> Thanks,
>> Poonam
>>
>>
>


More information about the serviceability-dev mailing list