RFR (XS): 8165681 ClassLoad and ClassPrepare JVMTI events are missed in the start phase

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Sep 12 03:58:14 UTC 2016


On 9/11/16 18:49, David Holmes wrote:
> Hi Serguei,
>
> On 12/09/2016 11:15 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review the one-liner fix for:
>>   https://bugs.openjdk.java.net/browse/JDK-8165681
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8165681-jvmti-events.hs1/ 
>>
>>
>> Summary:
>>   The JVMTI spec tells the ClassLoad and ClassPrepare events can be send
>> during start phase.
>>   The new test below identified that they are missed because of this bug
>> in JVMTI.
>>   The fix is to add the events to the set of the set of the 
>> EARLY_EVENT_BITS.
>
> Seems fine.

Thank you for the review, David.

> Good to see the additional test coverage.

Thanks to D. Dmitriev for the additional coverage.

Thanks,
Serguei


>
> Thanks,
> David
>
>> Testing:
>>   The following new test covers this issue:
>> test/serviceability/jvmti/ModuleAwareAgents/ClassLoadPrepare/VMEarly
>>   They are developed as a part of the following test enhancement:
>>     8150758 [TESTBUG] need jvmti tests for module aware agents
>>
>>   Additionally, the following tests were run:
>>     nsk.jvmti, nsk,jdi, jtreg com/sun/jdi and java/lang/instrument
>>
>>
>> Thanks,
>> Serguei




More information about the serviceability-dev mailing list