RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

[Ujwal Vangapally]

Thanks for the review Erik,

I will investigate more considering Daniel's comment.

Adding a public method to an interface is an incompatible source change 
unless there is a default body. On the other hand I am not sure how 
MXBean proxies will work when proxying an interface containing a default 
body. It would be interesting to check this.

kindly use below webrev for referring changes as webrev.00 is not 
accessible.

http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.01/

-Ujwal




On 8/3/2017 8:00 PM, Erik Gahlin wrote:
> Looks good, not a reviewer.
>
> Nit, saw that spaces before commas were missing in some method calls, 
> i.e. ",-1" instead of ", -1"
>
> Erik
>
>> Hi,
>>
>> kindly review the changes made.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8185003
>>
>> webrev: 
>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.00/
>>
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8185705
>>
>> Thanks,
>>
>> Ujwal.
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170803/7f4b79a5/attachment-0001.html>