[10] RFR: 8185164: GetOwnedMonitorInfo() returns incorrect owned monitor

[Daniel D. Daugherty]

On 8/7/17 2:54 AM, Yasumasa Suenaga wrote:
> Thanks Serguei, David,
>
> I uploaded webrev which includes @summary update and 4 indent:
>
>    http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.05/

make/test/JtregNative.gmk
     No comments.

src/share/vm/runtime/objectMonitor.cpp
     No comments.

test/serviceability/jvmti/GetOwnedMonitorInfo/GetOwnedMonitorInfoTest.java
     No comments.

test/serviceability/jvmti/GetOwnedMonitorInfo/libGetOwnedMonitorInfoTest.c
     No comments.

Thumbs up!

Dan

>
>
> Could you review and be a sponsor for it?
>
>
> Yasumasa
>
>
>
> 2017-08-07 17:35 GMT+09:00 serguei.spitsyn at oracle.com
> <serguei.spitsyn at oracle.com>:
>> On 8/6/17 21:50, David Holmes wrote:
>>> Hi Yasumasa,
>>>
>>> On 7/08/2017 2:02 PM, Yasumasa Suenaga wrote:
>>>> Hi David,
>>>>
>>>> I uploaded new webrev:
>>>>
>>>>     http://cr.openjdk.java.net/~ysuenaga/JDK-8185164/webrev.04/
>> . . .
>>>
>>>>> Style query: do we do indent of 2 or 4 in hotspot C code tests ?
>>>>
>>>> Fixed in C code.
>>>
>>> I was asking a question - I'm not sure if we use 2 or 4. Now looking at
>>> some other JVMTI tests they seem to use 4. I didn't do an exhaustive check
>>> to see if there is a predominant style.
>>
>> The indent was always 4 even for the nsk.jvmti tests.
>>
>>
>> Thanks,
>> Serguei
>>
>>> Thanks,
>>> David
>>>