[8u] RFR for JDK-8169961: Memory leak after debugging session

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Wed Aug 23 19:18:57 UTC 2017


Hi Shafi,

It looks good.

Thanks,
Serguei


On 8/23/17 07:34, Shafi Ahmad wrote:
> Hi,
>   
> Please review the backport of bug: "JDK-8169961: Memory leak after debugging session" to jdk8u-dev
>
> Please note that this is not a clean backport due to small conflict -
> shshahma at slc12kkg:/scratch/shshahma/Java/jdk8u-dev-base/jdk$ cat src/share/classes/com/sun/tools/jdi/TargetVM.java.rej
> --- TargetVM.java
> +++ TargetVM.java
> @@ -41,7 +41,7 @@
>   
>   public class TargetVM implements Runnable {
>       private Map<String, Packet> waitingQueue = new HashMap<>(32,0.75f);
> -    private boolean shouldListen = true;
> +    private volatile boolean shouldListen = true;
>       private List<EventQueue> eventQueues = Collections.synchronizedList(new ArrayList<>(2));
>       private VirtualMachineImpl vm;
>       private Connection connection;
>
> 	
> Webrev: http://cr.openjdk.java.net/~shshahma/8169961/jdk8u-webrev.01/
> Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8169961
> Original patch pushed to jdk10: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/cbc248de6505
>
> Test:  Run jprt -testset core, jtreg test jdk/test/com/sun/jdi.
>
> Regards,
> Shafi



More information about the serviceability-dev mailing list