RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

[Ujwal Vangapally]

kindly see the updated webrev incorporating review comments.

webrev : 
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.06/

Thanks

Ujwal


On 8/11/2017 11:41 PM, mandy chung wrote:
>
>
>
> On 8/9/17 10:15 AM, Ujwal Vangapally wrote:
>>
>> Thanks for the review Mandy,
>>
>> kindly see my comments inline.
>>
>> webrev: 
>> http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/webrev.03/
>>
>>
> 688 /** 689 * This is equivalent to calling: I meant to keep the first 
> sentence and then followed with "This is equivalent to calling:" like 
> this: /**
> * Returns the thread info for each thread whose ID is in the input 
> array {@code ids},
> * with stack trace  and synchronization information.
>     * This is equivalent to calling:
> 775 * @implSpec if not implemented, the method will throw
> 776 * an UnsupportedOperationException. can be simplified to: 
> @implSpec The default implementation throws {@code
> UnsupportedOperationException
> }
>
> 785 * @return an array of {@link ThreadInfo} for all live threads. 
> This is cut-n-paste error from dumpAllThreads. See the @return from 
> getThreadInfo. src/java.management/share/native/include/jmm.h 53 
> JMM_VERSION_10 = 0x20010203, // JDK 10 You modify the signature of an 
> existing entry point. This is incompatible change and so may bump it 
> to 0x20020000. JMM_VERSION should be the current version (i.e. = 
> JMM_VERSION_10). We should look at all references to JMM_VERSION_XXX 
> (in VM and library). For example,in 
> src/java.management/share/native/libmanagement/management.c 
> jmm_interface = (JmmInterface*) JVM_GetManagement(JMM_VERSION_1_0); In 
> management.cpp, in Management::get_jmm_interface(int version) #if 
> INCLUDE_MANAGEMENT if (version == JMM_VERSION_1_0) { return (void*) 
> &jmm_interface; } #endif // INCLUDE_MANAGEMENT return NULL; } The 
> library should use the current version. The change in other files look 
> fine. Mandy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20170828/a6c886e9/attachment.html>