RFR: JDK-8191914: (XS): New SA test timeout on windows

Sharath Ballal sharath.ballal at oracle.com
Fri Dec 1 06:05:19 UTC 2017


Looks Good Jini.


Thanks,
Sharath


-----Original Message-----
From: David Holmes 
Sent: Friday, December 01, 2017 10:18 AM
To: Jini George; serviceability-dev at openjdk.java.net
Subject: Re: RFR: JDK-8191914: (XS): New SA test timeout on windows

Looks good!

Thanks for the additional simplifications using OutputAnalyzer.

David

On 1/12/2017 2:37 PM, Jini George wrote:
> Thank you, David, for the review, and for pointing out about the other 
> tests. I went through the other tests and corrected a few more. Would 
> you please take a look at the modified webrev ?
> 
> http://cr.openjdk.java.net/~jgeorge/8191914/webrev.01/index.html
> 
> Thanks,
> Jini.
> 
> On 11/30/2017 1:27 PM, David Holmes wrote:
>> Hi Jini,
>>
>> Fix looks good. Have you checked the other tests for a similar problem?
>>
>> Thanks,
>> David
>>
>> On 30/11/2017 4:34 PM, Jini George wrote:
>>> Hello,
>>>
>>> Requesting reviews for a very small change to avoid the timeout of 
>>> the recently added TestJhsdbJStackLock.java test case on windows. 
>>> The change includes unquarantining this test on windows also.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8191914
>>> Webrev: http://cr.openjdk.java.net/~jgeorge/8191914/webrev.00/
>>>
>>> Thanks,
>>> Jini.


More information about the serviceability-dev mailing list