RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c
Alex Menkov
alexey.menkov at oracle.com
Thu Dec 7 18:50:47 UTC 2017
Looks like we already have definitions to workaround Visual Studio
issues (including absence of PRId64) in
open/src/hotspot/share/utilities/globalDefinitions_visCPP.hpp
It would be better to reuse it (to have all workarounds in a single place)
I suppose to utilize it you need
#include "utilities/globalDefinitions.hpp"
It includes corresponding "globalDefinitions_*.hpp" depending on the
compiler used.
--alex
On 12/07/2017 07:21, Langer, Christoph wrote:
> Hi,
>
> please review the first extracted patch from 8192978. This one is about
> correcting the jlong format string in
> src/jdk.jdi/share/native/libdt_shmem/shmemBase.c.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8193183
>
> WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193183.0/
>
> I believe the libdt_shmem is only built on windows.
>
> Thanks,
>
> Christoph
>
More information about the serviceability-dev
mailing list