RFR (XS): 8193183: Fix format string in libdt_shmem/shmemBase.c

[David Holmes]

On 8/12/2017 1:21 AM, Langer, Christoph wrote:
> Hi,
> 
> please review the first extracted patch from 8192978. This one is about 
> correcting the jlong format string in 
> src/jdk.jdi/share/native/libdt_shmem/shmemBase.c.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8193183
> 
> WebRev: http://cr.openjdk.java.net/~clanger/webrevs/8193183.0/
> 
> I believe the libdt_shmem is only built on windows.

Okay ... in that case why do you need the

+ #if defined(_WIN32)

? As there is no definition of PRId64 for non-Windows any attempt to 
build on non-Windows will fail. If you don't use the ifdef and simply 
use %I64d then any attempt to build on non-windows will also fail.

Or we can continue the illusion this might be built on non-Windows and 
add a definition that works in all cases - like hotspot's INT64_FORMAT.

Cheers,
David

> Thanks,
> 
> Christoph
>