RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

[Sharath Ballal]

Can I get one more review pls ?

Thanks,
Sharath


-----Original Message-----
From: Sharath Ballal 
Sent: Thursday, December 07, 2017 2:25 PM
To: Jini Susan George; serviceability-dev at openjdk.java.net
Subject: RE: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

Thanks Jini.  I have changed the testcase to run with both -Xint and -Xcomp.
Updated webrev is http://cr.openjdk.java.net/~sballal/8193124/webrev.01/ 


Thanks,
Sharath


-----Original Message-----
From: Jini George 
Sent: Wednesday, December 06, 2017 10:40 PM
To: Sharath Ballal; serviceability-dev at openjdk.java.net
Subject: Re: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

Hi Sharath,

For ClhsdbFindPC.java, the test case would fail if it gets invoked with -Xcomp. So, it might be better to invoke LingeredApp only with -Xint or only with -Xcomp (and if so, check for the "In code in NMethod" string).

Other than this, the rest of it looks good to me.

Thanks!
Jini.


On 12/6/2017 9:40 PM, Sharath Ballal wrote:
> Hello,
> 
> Pls review changes for the following issue:
> 
> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8193124
> 
> Webrev: http://cr.openjdk.java.net/~sballal/8193124/webrev.00/
> 
> The tests have passed in JPRT and Mach5.
> 
> Thanks,
> 
> Sharath
>