RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

[Sharath Ballal]

Thanks for the review Sundar.


Thanks,
Sharath


-----Original Message-----
From: Sundararajan Athijegannathan 
Sent: Friday, December 08, 2017 11:26 AM
To: serviceability-dev at openjdk.java.net
Subject: Re: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and findpc commands

Looks good

-Sundar

On 08/12/17, 11:13 AM, Chris Plummer wrote:
> Hi Sharath,
>
> Overall looks good. I actually ran ClhsdbFindPC so I could look at the 
> output and better understand how it works. One thing I noticed is that 
> ClhsdbLauncher echoes the hsdb prompt and the output of the command, 
> but not the command itself. I tinkered with it a bit to see if this 
> could be fixed, but couldn't figure out how to inject the command into 
> the output stream at the right point. I think maybe you need to dump 
> the process output before each command is executed (this will print 
> any previous command's output, and then the prompt), followed by 
> printing the command itself. If this is possible, maybe consider this 
> for an RFE.
>
> FYI, you still need a "R"eviewer.
>
> thanks,
>
> Chris
>
> On 12/7/17 9:04 PM, Sharath Ballal wrote:
>> Can I get one more review pls ?
>>
>> Thanks,
>> Sharath
>>
>>
>> -----Original Message-----
>> From: Sharath Ballal
>> Sent: Thursday, December 07, 2017 2:25 PM
>> To: Jini Susan George; serviceability-dev at openjdk.java.net
>> Subject: RE: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and 
>> findpc commands
>>
>> Thanks Jini.  I have changed the testcase to run with both -Xint and 
>> -Xcomp.
>> Updated webrev is 
>> http://cr.openjdk.java.net/~sballal/8193124/webrev.01/
>>
>>
>> Thanks,
>> Sharath
>>
>>
>> -----Original Message-----
>> From: Jini George
>> Sent: Wednesday, December 06, 2017 10:40 PM
>> To: Sharath Ballal; serviceability-dev at openjdk.java.net
>> Subject: Re: RFR: JDK-8193124 - SA: Testcases for clhsdb jdis and 
>> findpc commands
>>
>> Hi Sharath,
>>
>> For ClhsdbFindPC.java, the test case would fail if it gets invoked 
>> with -Xcomp. So, it might be better to invoke LingeredApp only with 
>> -Xint or only with -Xcomp (and if so, check for the "In code in 
>> NMethod" string).
>>
>> Other than this, the rest of it looks good to me.
>>
>> Thanks!
>> Jini.
>>
>>
>> On 12/6/2017 9:40 PM, Sharath Ballal wrote:
>>> Hello,
>>>
>>> Pls review changes for the following issue:
>>>
>>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8193124
>>>
>>> Webrev: http://cr.openjdk.java.net/~sballal/8193124/webrev.00/
>>>
>>> The tests have passed in JPRT and Mach5.
>>>
>>> Thanks,
>>>
>>> Sharath
>>>
>