[10] RFR for JDK-8170299: Debugger does not stop inside the low memory notifications code [internal]

[Shafi Ahmad]

Thank you Mandy and David.

 

I am sorry, somehow I missed your earlier comment regarding the RFE.

 

>> This is a spec change.  Is this intentional?

Yes, this change is required as this is referenced inside  MemoryImpl.java.

I will file a separate RFE for adding hasListeners().

 

I will send the updated webrev after incorporating the review comment.

 

Regards,

Shafi

 

 

 

From: mandy chung 
Sent: Tuesday, December 12, 2017 2:35 AM
To: Shafi Ahmad <shafi.s.ahmad at oracle.com>
Cc: serviceability-dev at openjdk.java.net
Subject: Re: [10] RFR for JDK-8170299: Debugger does not stop inside the low memory notifications code [internal]

 

 

On 12/11/17 2:31 AM, Shafi Ahmad wrote:

 

The method hasListeners() is referenced  inside MemoryImpl.java and defined in  NotificationEmitterSupport.

This method is not present in  NotificationBroadcasterSupport so I added it to NotificationBroadcasterSupport.

 


This is a spec change.  Is this intentional?  I replied in Sept in reviewing an earlier version [1] that this cannot be backported.  If you intend to make this spec change, it's better to separate this RFE and it requires CSR.




Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8170299

Webrev link: HYPERLINK "http://cr.openjdk.java.net/%7Eshshahma/8170299/webrev.02/"http://cr.openjdk.java.net/~shshahma/8170299/webrev.02/

 


MemoryImpl.java

 189                     th.setName("Debugger");
 
this is not a debugger thread.  Maybe rename it to 
"MemoryPool notification thread"?
 
Mandy

[1] http://mail.openjdk.java.net/pipermail/serviceability-dev/2017-September/021836.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20171211/29448eeb/attachment.html>