RFR: JDK-8192985: SA: Test cases for the clhsdb 'inspect', 'scanoops' and 'printas' commands

[Chris Plummer]

Hi Jini,

On 12/12/17 2:38 AM, Jini George wrote:
> Thank you, Chris. Answers inline.
>
> On 12/12/2017 4:43 AM, Chris Plummer wrote:
>>> These are the new test cases for the following clhsdb commands:
>>> 1. inspect
>> tokensMap code can all move to inside the "if" block that follows it.
> Done.
>
>>> 2. scanoops
>> When will "universe" not return any output?
> universeOutput could be null if there are attach permission issues
Why would this ever happen in a testing environment?
> and if we are skipping the test. 
I'm not sure what you meant by this. If we are running the test, how are 
we skipping it?
> I have added these comments there for clarity.
My concern is that logic like this could be hiding some other issue. 
It's possible that some other bug causes universeOutput to be null on 
every run we do, yet the test will show as passed.

thanks,

Chris
>
> I have a new webrev at:
>
> http://cr.openjdk.java.net/~jgeorge/8192985/webrev.01/
>
> Thanks,
> Jini.