RFR: JDK-8180709: java -javaagent:agent.jar with run-time that does not contain java.instrument prints confusing error

[serguei.spitsyn at oracle.com]

Chris pointed out, there is no point to run the tier5.
It is enough to run the <open>:jdk_instrument.

Thanks,
Serguei


On 12/19/17 17:26, serguei.spitsyn at oracle.com wrote:
> Gary,
>
> What tests did you run?
> Event though the fix looks save it is still a good idea to submit a 
> mach5 job that includes the :jdk_instrument test suite. Most likely, 
> it is in the hs-tier5 (or more specifically, hs-tier5-rt)
>
> Thanks,
> Serguei
>
>
> On 12/19/17 14:50, Chris Plummer wrote:
>> I can push it this evening if no one else grabs it first (need to 
>> step out for a bit and won't be able to monitor CI results). Please 
>> produce a changeset first.
>>
>> thanks,
>>
>> Chris
>>
>> On 12/19/17 2:47 PM, gary.adams at oracle.com wrote:
>>> Now comes the catch ...
>>>     I'll need a sponsor.
>>>
>>> On 12/19/17 5:12 PM, Chris Plummer wrote:
>>>> +1
>>>>
>>>> Thanks, Chris
>>>>
>>>> On 12/19/17 8:57 AM, serguei.spitsyn at oracle.com wrote:
>>>>> Looks good.
>>>>>
>>>>> Thanks, Serguei
>>>>>
>>>>>
>>>>> On 12/19/17 06:58, Gary Adams wrote:
>>>>>> A refreshed webrev is vailable
>>>>>>   Webrev: http://cr.openjdk.java.net/~gadams/8180709/webrev.01/
>>>>>>
>>>>>> On 12/19/17, 5:10 AM, Alan Bateman wrote:
>>>>>>> On 18/12/2017 21:14, gary.adams at oracle.com wrote:
>>>>>>>> I can just the error message.
>>>>>>>> What would you like it to say?
>>>>>>>>
>>>>>>>> "Module java.instrument may be missing"
>>>>>>> Technically it may be that the java.instrument module is not 
>>>>>>> observable but saying that it may not be in the run-time image 
>>>>>>> is probably clearer to the clearer. The main thing is to connect 
>>>>>>> it to the java.instrument module, other details are useful too, 
>>>>>>> say where someone has a corrupt installation or the wrong 
>>>>>>> permissions on the library.
>>>>>>>
>>>>>>> -Alan
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>