RFR: 8173607: JMX RMI connector should be in its own module
    Mandy Chung 
    mandy.chung at oracle.com
       
    Thu Feb  2 02:41:42 UTC 2017
    
    
  
> On Feb 1, 2017, at 7:29 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Here is the updated webrev, rebased after pulling JDK-8173608, and with
> your feedback below integrated.
> 
> I am pleased to report that java.management no longer requires
> java.rmi or java.naming :-)
> 
This is great!
> Compared to previous version, then RMIExporter has been moved
> to java.management.rmi, various module-info.java have been
> cleaned up, some @modules in tests have been updated (mostly
> due to the RMIExporter move).
> 
> I have also improved some javadoc comments in JMXConnectorFactory.java
> No changes in build files compared to webrev.05
> 
> http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.06
Does java.management still depend on java.base/jdk.internal.module?
> http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.06/java.management.rmi-summary.html
> 
Maybe the first sentence of @provides could be simplified to:
A provider of JMXConnectorProvider for the RMI protocol.
A provider of JMXConnectorServerProvider for the RMI protocol.
Otherwise looks good.
Mandy
    
    
More information about the serviceability-dev
mailing list