8173941 Re: SA does not work if executable is DSO

[Volker Simonis]

On Fri, Feb 10, 2017 at 10:40 AM, Andrew Haley <aph at redhat.com> wrote:
> On 10/02/17 03:13, Yasumasa Suenaga wrote:
>> We can calculate start address of executable (java command) through entry
>> point.
>> I updated webrev:
>>
>>   http://cr.openjdk.java.net/~ysuenaga/JDK-8173941/webrev.01/
>>
>> This patch can ignore page size.
>
> Excellent.  I think this is safe for JDK 9, but there may be some
> argument about whether we'll be able to get it in now.  I'm happy to
> approve it, but I guess we should appeal to hotspot-dev and see what
> people say.
>

I haven't looked at this change in full detail until now so this is
not a review. But the change looks reasonable and non-intrusive so I
strongly support its integration into jdk9.

It also doesn't touch the libjvm.so which means it can't introduce any
harm. Second, it's good to see that somebody cares for the SA tools.
It would be nice if somebody from the SA team could have a look at
this and sponsor it.

@Andrew: as this bug is assigned to you, I'd suggest to change it's
status to open, the priority to P3 and target it for 9 (i.e. Fix
Version = 9).

Regards,
Volker


> Andrew.
>