RFR: JDK-8173896: SA: BasicLauncherTest.java (printmdo) fails for Client VM and Server VM with emulated-client

[Jini George]

Thank you, Serguei, for the review. I have addressed your comments and 
have a revised webrev at:

http://cr.openjdk.java.net/~jgeorge/8173896/webrev.01/ 
<http://cr.openjdk.java.net/%7Ejgeorge/8173896/webrev.01/>

-Jini.

On 2/13/2017 11:55 AM, serguei.spitsyn at oracle.com wrote:
> Hi Jini,
>
> It looks pretty good to me.
> A couple of comments.
>
> http://cr.openjdk.java.net/%7Ejgeorge/8173896/webrev.00/hotspot/test/serviceability/sa/TestPrintMdo.java.html 
>
>
> It seems these exports are not really needed:
>
>   29 import java.io.BufferedInputStream;
>   31 import java.io.FileInputStream;
>
>
> This line looks strange as the variable of type OutputStream is called 
> "input":
>  127         OutputStream input = p.getOutputStream();
>
> Adding a comment explaining why is that would be nice.
>
>
> Thanks,
> Serguei
>
> On 2/11/17 04:32, Jini George wrote:
>>
>> Could I pls get reviews done for the SA testbug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8173896
>>
>> Webrev: http://cr.openjdk.java.net/~jgeorge/8173896/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ejgeorge/8173896/webrev.00/index.html>
>>
>> Thanks,
>>
>> Jini.
>>
>> <http://cr.openjdk.java.net/%7Ejgeorge/8173896/webrev.00/index.html>
>>
>> <http://cr.openjdk.java.net/%7Ejgeorge/8173896/webrev.00/index.html>
>>