RFR : JDK-8174915 - Improve error handing for Jdp tests under sun/management/jdp

Daniel Fuchs daniel.fuchs at oracle.com
Tue Feb 21 10:21:04 UTC 2017


Hi Amit,

Looks good to me.
maybe you could add a comment in DynanicLauncher.java:

              // This exception is thrown by JdpTestCase.java when
              // something goes wrong. For instance, see
              // JdpTestCase::shutdown()
   62         output.shouldNotContain("java.lang.Exception:");

No need to produce a new webrev!

best regards,

-- daniel

On 20/02/17 07:22, Amit Sapre wrote:
> Hello,
>
>
>
> Please review minor improvements to jdp test helper class to handle
> error conditions.
>
>
>
> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174915
>
> Webrev :
> http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174915/webrev.00/
>
>
>
> Thanks,
>
> Amit
>



More information about the serviceability-dev mailing list